feat: add opentelemetry-exporter-http-transport package#5194
Conversation
|
|
||
| Core package (no HTTP backend included):: | ||
|
|
||
| pip install opentelemetry-exporter-http-transport |
There was a problem hiding this comment.
If this is specific to otlp over http, should the package name reflect that: opentelemetry-exporter-otlp-http-transport
There was a problem hiding this comment.
I was actually debating this exact naming decision, I decided that opentelemetry-exporter-http-transport might be slightly more appropriate than opentelemetry-exporter-otlp-http-transport given that we might want to use the transport abstraction for non-OTLP exporters (e.g. Jaeger). That being said, I still opted to include the OTLPHTTPClient inside this package since it's pretty lean and will be reused by the Proto + JSON HTTP exporters, but we could even break this off into another package, but my thought is this would be a bit overkill. WDYT?
There was a problem hiding this comment.
i think either is ok really. If the plan is to use this for exporters other than otlp, then i agree it makes more sense to keep it this way
There was a problem hiding this comment.
Shouldn't this be named opentelemetry-exporter-otlp-http-common for consistency with the rest of the packages?
There was a problem hiding this comment.
@ocelotl If we were to use this for non-OTLP exporter implementations (e.g. Prometheus remote-write or Zipkin), then it would make more sense to omit the otlp name. However, I'm also open to keeping it in - this was just my original thought process.
|
Thanks for the PR! Just a heads-up: we no longer update Please add the appropriate changelog fragment for this change instead of editing |
codeboten
left a comment
codeboten
left a comment
There was a problem hiding this comment.
Is there already a branch somewhere showing how this package can be used inside some of the other http exporters?
@codeboten I've opened #5219 which includes the full changes updating the OTLP Proto HTTP exporter to use this new package. I've also switched to start using |
5 participants
Description
Adds a common
opentelemetry-exporter-http-transportpackage that will be utilized by multiple HTTP exporter packages (initially OTLP JSON) to abstract away and generalize underlying HTTP transport implementations and exporting with OTLP. Introducing this package will significantly reduce the amount of code duplication present in HTTP exporters and will allow for the usage of alternative HTTP client libraries.Fixes #3439, #4171, #1003, #2990
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Does This PR Require a Contrib Repo Change?
Checklist: